Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally using graceful-fs if it's available #70

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adam-lynch
Copy link

@adam-lynch adam-lynch changed the title Optional using graceful-fs if it's available Optionally using graceful-fs if it's available Dec 8, 2014
@mmalecki
Copy link
Collaborator

mmalecki commented Dec 9, 2014

I think we should just add graceful-fs as an explicit dependency and potentially use it instead of controlling concurrency (iirc, concurrency control was introduced to prevent running out of fd's) (cc @AvianFlu)

@jprichardson
Copy link

It'd be cool to get this merged in the meantime as this PR doesn't require the addition of any dependency. Any projects that depend up on ncp could then also use graceful-fs and leverage the benefits of graceful-fs in ncp without any practical cost to ncp or its codebase.

@tracker1
Copy link

I think this is a nice change... :-) I don't like hard dependencies for stuff like this (considering many don't npm dedupe their repos, and often version settings leave multiple versions, even if they're actually compatible for the use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants