-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clamp progress bar indicator width and height to never drop below zero when calculating size. #17816
base: master
Are you sure you want to change the base?
Conversation
… when calculating size. Fixes AvaloniaUI#17393
You can test this PR using the following package version. |
Please read the following Contributor License Agreement (CLA). If you agree with the CLA, please reply with the following:
Contributor License AgreementContribution License AgreementThis Contribution License Agreement ( “Agreement” ) is agreed to by the party signing below ( “You” ), 1. Definitions. “Code” means the computer software code, whether in human-readable or machine-executable form, “Project” means any of the projects owned or managed by AvaloniaUI OÜ and offered under a license “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any “Submission” means the Code and any other copyrightable material Submitted by You, including any 2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any 3. Originality of Work. You represent that each of Your Submissions is entirely Your 4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else 5. Licenses. a. Copyright License. You grant AvaloniaUI OÜ, and those who receive the Submission directly b. Patent License. You grant AvaloniaUI OÜ, and those who receive the Submission directly or c. Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement. 6. Representations and Warranties. You represent that You are legally entitled to grant the above 7. Notice to AvaloniaUI OÜ. You agree to notify AvaloniaUI OÜ in writing of any facts or 8. Information about Submissions. You agree that contributions to Projects and information about 9. Governing Law/Jurisdiction. This Agreement is governed by the laws of the Republic of Estonia, and 10. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and AvaloniaUI OÜ dedicates this Contribution License Agreement to the public domain according to the Creative Commons CC0 1. |
@cla-avalonia agree |
What does the pull request do?
Simply clamps the width and height values to never go under zero when calculating indicator size.
What is the current behavior?
If padding is set, an exception is thrown on first draw as the control has no bounds yet (
0, 0
) and the padding offset * the percent results in a negative value.i.e
What is the updated/expected behavior with this PR?
The clamping of the values means that the control should never calculate its indicator size to drop below zero and thus never throw an exception.
How was the solution implemented (if it's not obvious)?
Math.Clamp(...)
isn't available in netstandard2.0 thus a simple ternary assignment is used to check if the value is below zero, if so, assign zero, else assign the calculated value.Checklist
Breaking changes
None
Obsoletions / Deprecations
None
Fixed issues
Fixes #17393