Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try fix Korean IME on iOS #17680

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Try fix Korean IME on iOS #17680

wants to merge 1 commit into from

Conversation

kerams
Copy link

@kerams kerams commented Dec 3, 2024

What does the pull request do?

Tries to fix #16956 on iOS.

What is the current behavior?

What is the updated/expected behavior with this PR?

See #16956

How was the solution implemented (if it's not obvious)?

With in a text box, when the user types , iOS invokes IUIKeyInput.DeleteBackward to remove , and then IUIKeyInput.InsertText with . Further typing should result in another delete followed by the insertion of .

However, the second IUIKeyInput.DeleteBackward does not currently happen and is inserted instead, producing 서ㄴ, probably due to how the previous delete was handled internally (resulting in the wrong return value from IUITextInput.TextInRange). With my change it is possible to type 3- and 4-character Korean syllabic blocks, but on only the first syllable. Additionally, manual deletion does not remove the entire syllable but only its last part ( becomes when deleting), which is the norm for Korean.

Sadly, further syllables continue to be broken, and manual deletes without calling keydown only select the final character. I'd appreciate any tips, especially describing why and how the double key up/down backspace invocation is required.

Checklist

Breaking changes

Obsoletions / Deprecations

@kerams kerams changed the title Try fix Korean IME on Android Try fix Korean IME on iOS Dec 3, 2024
@kerams
Copy link
Author

kerams commented Dec 12, 2024

Does Avalonia do any internal postprocessing of text entered in a TextBox? When I set the implementation of IUIKeyInput.DeleteBackward to be empty, I'd expect to see ㅅ서선 when typing , , , because IUIKeyInput.InsertText appends text, yet the text box correctly contains just despite disregarding the issued deletes.

I don't know how to explain this without the said postprocessing, and not sure I can fix the problem without understanding how this behavior is possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to type Korean 3-letter syllabic blocks
1 participant