Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Tries to fix #16956 on iOS.
What is the current behavior?
What is the updated/expected behavior with this PR?
See #16956
How was the solution implemented (if it's not obvious)?
With
ㅅ
in a text box, when the user typesㅓ
, iOS invokesIUIKeyInput.DeleteBackward
to removeㅅ
, and thenIUIKeyInput.InsertText
with서
. Further typingㄴ
should result in another delete followed by the insertion of선
.However, the second
IUIKeyInput.DeleteBackward
does not currently happen andㄴ
is inserted instead, producing서ㄴ
, probably due to how the previous delete was handled internally (resulting in the wrong return value fromIUITextInput.TextInRange
). With my change it is possible to type 3- and 4-character Korean syllabic blocks, but on only the first syllable. Additionally, manual deletion does not remove the entire syllable but only its last part (선
becomes서
when deleting), which is the norm for Korean.Sadly, further syllables continue to be broken, and manual deletes without calling keydown only select the final character. I'd appreciate any tips, especially describing why and how the double key up/down backspace invocation is required.
Checklist
Breaking changes
Obsoletions / Deprecations