Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure VirtualizingStackPanel correct element size estimate and fix #17460 #17461

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

BobLd
Copy link
Contributor

@BobLd BobLd commented Nov 9, 2024

What does the pull request do?

Ensure VirtualizingStackPanel's _lastEstimatedElementSizeU is set before calling CalculateDesiredSize().

As a result, the vertical scroll bar will be correctly sized.

What is the current behavior?

The Vertical scroll bar size is not correct until the view is scroll down to its maximum.

What is the updated/expected behavior with this PR?

Checklist

Breaking changes

n/a

Obsoletions / Deprecations

n/a

Fixed issues

Fixes #17460

@BobLd
Copy link
Contributor Author

BobLd commented Nov 9, 2024

This is one possible solution that fixes the problem. I'll let the Avalonia experts correct me if there's a better way

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.3.999-cibuild0053175-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@BobLd
Copy link
Contributor Author

BobLd commented Nov 30, 2024

@grokys is there anything I can do here to help the review?

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.3.999-cibuild0053787-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect vertical scrollbar size in VirtualizingStackPanel
2 participants