Ensure VirtualizingStackPanel correct element size estimate and fix #17460 #17461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is one possible solution that fixes the problem. I'll let the Avalonia experts correct me if there's a better way |
|
You can test this PR using the following package version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Ensure
VirtualizingStackPanel's_lastEstimatedElementSizeUis set before callingCalculateDesiredSize().As a result, the vertical scroll bar will be correctly sized.
What is the current behavior?
The Vertical scroll bar size is not correct until the view is scroll down to its maximum.
What is the updated/expected behavior with this PR?
Checklist
Breaking changes
n/a
Obsoletions / Deprecations
n/a
Fixed issues
Fixes #17460