Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: respect CanResize on macOS regardless of SystemDecorations #17355

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BAndysc
Copy link
Contributor

@BAndysc BAndysc commented Oct 26, 2024

What does the pull request do?

This PR moves NSWindowStyleMaskResizable flag application from SystemDecorationsFull case outside of the switch, so this flag is applied also for other system decorations.

What is the current behavior?

NSWindowStyleMaskResizable is applied only for SystemDecorationsFull. Other decorations make windows not resizable.

What is the updated/expected behavior with this PR?

NSWindowStyleMaskResizable is applied regardless of SystemDecorations, it always follows CanResize property.

Checklist

Breaking changes

Windows which have decorations set to None or BorderOnly and CanResize=true (default) will now become resizable, which can be unexpected for some people. But this behaviour is expected since CanResize is set to true, isn't it?

Obsoletions / Deprecations

Fixed issues

Fixes #17295

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.3.999-cibuild0052798-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@BAndysc BAndysc changed the title Fix: respect CanResize on macOS regardless of SystemDecorations [WIP] Fix: respect CanResize on macOS regardless of SystemDecorations Oct 26, 2024
@BAndysc BAndysc force-pushed the fix_macos_canresize branch from cec9bc3 to a92a773 Compare October 27, 2024 16:55
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.3.999-cibuild0052824-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@BAndysc BAndysc force-pushed the fix_macos_canresize branch from a92a773 to 09087b9 Compare October 27, 2024 20:20
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.3.999-cibuild0052826-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@BAndysc BAndysc force-pushed the fix_macos_canresize branch from 09087b9 to eb857ce Compare October 27, 2024 21:46
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.3.999-cibuild0052828-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@BAndysc BAndysc force-pushed the fix_macos_canresize branch from eb857ce to 7788939 Compare October 27, 2024 23:01
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.3.999-cibuild0052830-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@BAndysc BAndysc changed the title [WIP] Fix: respect CanResize on macOS regardless of SystemDecorations Fix: respect CanResize on macOS regardless of SystemDecorations Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[macOS] CanResize is ignored when SystemDecorations = None
3 participants