-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Headless TimeProvider support #16226
Open
maxkatz6
wants to merge
14
commits into
master
Choose a base branch
from
headless-timers
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any alternative naming ideas are welcomed. |
MrJul
reviewed
Jul 4, 2024
You can test this PR using the following package version. |
@maxkatz6 Does Win32/macOS/Linux platforms support custom FPS adjustment? |
@laolarou726 no. It's not possible, when render timer is driven by OS vsync. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
In Avalonia 0.10 we previously had APIs allowing custom defined IClock implementations, that were primarily useful for unit testing. Typical scenario is skipping time for animations or dispatcher timers without actually waiting in real time.
With 11.0 refactoring we have lost this API with an idea to reimplement it in some more controlled form.
This PR is partially inspired by Flutter
pump
method used in unit testing, as well as .NET 8 TimeProvider APIs.Also, this PR adds Dispatcher.Idle headless extension, that is better suited to simulate user idle, comparing to RunJobs method.
New APIs:
How was the solution implemented (if it's not obvious)?
Compositor
now relies onIRenderLoopTask
callback timestamp instead of usingStopwatch
. This timestamp then can be re-defined by the headless platform.Dispatcher
now allows to replaceStopwatch
usage if that's required by the platform implementation. Headless does that. Note, it has no effect on most backends that don't use managed dispatcher.MediaContext
(including animations engine) now usesDispatcher.Now
instead ofStopwatch
. Combined with previous, it also can be controlled by the headless platform.There are some other usages of Stopwatch in the codebase but used for profiling and logging needs. Not really a target for these changes.
Checklist