Implemented MultiBindingExpression
#16219
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Swap `target` and `targetProperty` order to make it consistent with other similar methods - Make `targetProperty` nullable as it will need to be null for `MultiBinding`
It will need to be null for `MultiBinding`.
It will need to be null for `MultiBinding`.
Only publish unset value if we've already published a value.
grokys
added
enhancement
backport-candidate-11.1.x
|
You can test this PR using the following package version. |
|
You can test this PR using the following package version. |
MrJul
reviewed
Jul 4, 2024
| converted = _targetNullValue; | ||
| if (converted == AvaloniaProperty.UnsetValue) | ||
| converted = _fallbackValue; | ||
| PublishValue(converted); |
There was a problem hiding this comment.
This doesn't seem to handle BindingOperations.DoNothing anymore: DoNothing is directly published to the target.
MultiValueConverterTests is supposed to check this but the test passes for the wrong reason, because DoNothingType isn't convertible to the target string type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Implements
MultiBindingExpressionand makesMultiBindinguse it instead of relying on the now-obsolete APIs it was using before.Shouldn't have much user-facing effect, though does allow us to fix #16084
Also removes a couple of usages of the obsolete
IBinding.InitiateAPI from multi-binding tests and adds nullable annotations to that file.Fixed issues
Fixes #16084