Fix nunit tests adapter losing async locals #16157
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
NUnit actively uses
AsyncLocal
to globally storeTestContext
.Avalonia Headless integration with NUnit was messing up with
ExecutionContext
causing weird bugs like:How was the solution implemented (if it's not obvious)?
I couldn't understand exactly how was it broken, but my hypothesis is:
ExecutionContext
.TestContext
in theAsyncLocal
(which uses ExecutionContext) - https://github.com/nunit/nunit/blob/v3.13.3/src/NUnitFramework/framework/Internal/TestExecutionContext.cs#L154TestContext
of the first running test, caches it, and never invalidates.TestContext
via EstablishExecutionEnvironment. But it has no effect on Avalonia Tests, which don't use the sameExecutionContext
.EstablishExecutionEnvironment
on each tests also doesn't work, as it resetsSynchronizationContext
(!!!!) to NUnit's one as well, breaking anything Dispatcher related.And it was fixed by explicitly capturing
ExecutionContext
of the invoking test framework (NUnit in this case), and explicitly running tests in the same context, while keeping our ownSynchronizationContext
.Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues