Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Substack importer: account for user skipping both steps #96427

Open
wants to merge 6 commits into
base: trunk
Choose a base branch
from

Conversation

simison
Copy link
Member

@simison simison commented Nov 14, 2024

Proposed Changes

  • Adds a summary state when both content and subscriber importing were skipped. I don't think many people will end up at this screen, but if they do, now it's not a dead end at least.
Screenshot 2024-11-15 at 11 10 32

Why are these changes being made?

Testing Instructions

  • Test Substack importer
  • Skip both content and subscriber importers
  • Start over

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@simison simison requested a review from lezama November 14, 2024 18:35
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 14, 2024
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/substack-importer-double-skip on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Nov 14, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~63 bytes added 📈 [gzipped])

name    parsed_size           gzip_size
import       +471 B  (+0.1%)      +63 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@simison simison force-pushed the update/substack-importer-double-skip branch from 67d0b96 to eb4c305 Compare November 15, 2024 09:26
@simison
Copy link
Member Author

simison commented Nov 15, 2024

@crisbusquets I made something quick that feels slightly clunky and could probably be better, but I'm also fine shipping as-is. Lemme know what you think! Screenshot in the PR description.

@simison simison marked this pull request as ready for review November 15, 2024 09:46
@simison simison requested a review from a team as a code owner November 15, 2024 09:46
@crisbusquets
Copy link
Contributor

Thanks for the ping, @simison !

I had a design proposal for this (ZdugJ99VXJszZRSBfMNre4-fi-5443_27320), which is exactly what you posted, but without the CTA.

I'd adjust the spacing and the icon and the font color to match with the flow. I had Gray 50 in the Figma file, to make it more distinct from the titles, Gray 70.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. Subscriber Importer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants