-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Substack importer: account for user skipping both steps #96427
base: trunk
Are you sure you want to change the base?
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~63 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
67d0b96
to
eb4c305
Compare
@crisbusquets I made something quick that feels slightly clunky and could probably be better, but I'm also fine shipping as-is. Lemme know what you think! Screenshot in the PR description. |
Thanks for the ping, @simison ! I had a design proposal for this (ZdugJ99VXJszZRSBfMNre4-fi-5443_27320), which is exactly what you posted, but without the CTA. I'd adjust the spacing and the icon and the font color to match with the flow. I had |
Proposed Changes
Why are these changes being made?
Testing Instructions
Pre-merge Checklist