AMP: Fix too high refresh interval #663
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building, NPM reports the following error: > error Using target="_blank" without rel="noopener noreferrer" is a security risk: see https://mathiasbynens.github.io/rel-noopener react/jsx-no-target-blank This change fixes that by adding the required rel attribute to the link.
The refresh interval can be set by the site owner to any value. On AMP liveblogs this is used for the `data-poll-interval` in the `amp-live-list` but that value has to be greater than 15. https://amp.dev/documentation/examples/components/amp-live-list/ This change ensures that AMP Liveblogs enforce a minimum value of 15 for the interval.
| @@ -332,7 +332,7 @@ public static function build_entries_feed( $entries, $request, $post_id ) { | |||
| 'last' => get_query_var( 'liveblog_last', false ), | |||
| 'settings' => array( | |||
| 'entries_per_page' => WPCOM_Liveblog_Lazyloader::get_number_of_entries(), | |||
| 'refresh_interval' => WPCOM_Liveblog::get_refresh_interval(), | |||
| 'refresh_interval' => min( 15, WPCOM_Liveblog::get_refresh_interval() ), | |||
There was a problem hiding this comment.
Maybe put this in a constant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The refresh interval can be set by the site owner to any value. On AMP liveblogs this is used for the
data-poll-intervalin theamp-live-listbut that value has to be greater than 15. https://amp.dev/documentation/examples/components/amp-live-list/This change ensures that AMP Liveblogs have a minimum interval of 15.