Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to disable the static cache of the endpoint base #514

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rogertheriault
Copy link

@rogertheriault rogertheriault commented Aug 15, 2018

for users who need fine-grain control over the endpoint base, this allows selective or site-wide disabling of the static cache.

The static variable results in subsequent requests for the endpoint base bypassing any url filters.

This might be needed for a site that uses more than one domain, for example a different domain for wp-admin vs the front end.

This was deployed to SVN in r350550 on 2018-08-15

@rogertheriault rogertheriault changed the title Add an option to disable the static endpoint cache Add an option to disable the static cache of the endpoint base Aug 15, 2018
@mjangda
Copy link
Member

mjangda commented Aug 16, 2018

Should the static cache just be removed? How expensive is it to build the endpoint base?

@rogertheriault
Copy link
Author

I was thinking it should probably be dropped, but was not keen to break someone's site if they'd set up some elaborate filtering to get around the inability to filter :-) so @rebeccahum suggested just adding a filter that could be used just by affected sites.

I'm not clear why it was there. Static caches are handy but maybe not so handy for something that folks expect to be able to filter. It doesn't look like it saves that much processing.

But removing it entirely is probably something for a future release by @philipjohn

@philipjohn
Copy link
Contributor

for users who need fine-grain control over the endpoint base, this allows selective or site-wide disabling of the static cache.

Do we know of any one wanting to do this, or is it just a thing we think people might want?

@rogertheriault
Copy link
Author

Do we know of any one wanting to do this, or is it just a thing we think people might want?
Only the folks we implemented the filter for in SVN right now. I'm ok with just removing the static cache instead, if it's unnecessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants