Add filter to post_meta value #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases it is useful to have a more granular control over what post_meta is shown to the end user. Or modify some values before showing them to the user (json_decode, base64_decode, etc)
post-meta-inspector.php
Outdated
| @@ -93,7 +93,7 @@ public function post_meta_inspector() { | |||
| ?> | |||
| <?php foreach( $values as $value ) : ?> | |||
| <?php | |||
| $value = var_export( $value, true ); | |||
| $value = apply_filter( 'pmi_modify_post_meta_value', var_export( maybe_unserialize( $value ), true ), $key, $value ); | |||
There was a problem hiding this comment.
Two other things:
- The filter name should probably just be
pmi_post_meta_value; we're not actually modifying the value so the name is misleading. - Why are we unserializing now but weren't before?
There was a problem hiding this comment.
Why are we unserializing now but weren't before?
The WPcom version was maybe_unserializing so I ported that behavior here.
There was a problem hiding this comment.
The filter name should probably just be pmi_post_meta_value;
Good idea
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases it is useful to have a more granular control over what post_meta is shown to the end user. Or modify some values before showing them to the user (json_decode, base64_decode, etc)