Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fatal error exit #4043

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Fix fatal error exit #4043

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions lib/mayaUsd/utils/diagnosticDelegate.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,23 @@ class ErrorOnlyDelegate : public UsdUtilsCoalescingDiagnosticDelegate
{
UsdMayaDiagnosticDelegate::Flush();

// Note: TfLogCrash will do a hard abort of the process.
// The dynamic libraries will be unloaded in a random order and
// global variable will be destroyed. Unfortunately, USD holds a
// mutex while in the TfLogCrash function and trying to remove the
// diagnostic delegate (_waker) will also try to hold that mutex
// resulting in a dead-lock. Avoid this by avoiding to destroy
// the delegates
//
// Yes, this means we are leaking the delegates, but we are in
// the middle of crashing anyway, so it does not really matter.

_waker.release();
_flusher.release();
_batchedStatuses.release();
_batchedWarnings.release();
_batchedErrors.release();

TfLogCrash(
"FATAL ERROR",
msg,
Expand Down