MAYA-133671 - Add textured mode handling to topo grapher #4031
Conversation
Allows quickly reducing a graph to only a surface for when the viewport is in "untextured" mode.
| computeGraph(material, textured); | ||
| } | ||
|
|
||
| void TopoNeutralGraph::computeGraph(const mx::ElementPtr& material, bool textured) |
There was a problem hiding this comment.
Just one comment. Alice had recommended that I move away from having boolean parameters like this in favour of multiple methods. So in this case something like computeGraph and computeTexturedGraph. Just a suggestion though, up to you. I do think its a bit nicer that way.
There was a problem hiding this comment.
Although I guess the downside of that is you'd need an if statement on the textured parameter to call either computeGraph or computeTexturedGraph.
There was a problem hiding this comment.
And then the code of both functions end up identical except for three lines of code. I know of other C++ gurus that have a strict policy of using fully specified enums in this case. Especially useful when you start having calls like:
doSomething(true, false, true, true, false, false, false);
Sadly not something I can rework in the mayaUsdApi library as it needs to stay binary compatible. I can add constructors, but that is about it.
JGamache-autodesk
dismissed stale reviews from feldstj and frohnej-adsk
via
fe07c89
JGamache-autodesk
added
the
ready-for-merge
|
@seando-adsk ready for merge. Remaining preflight error is a known random failure of the testUsdExportPackage unit test. |
seando-adsk
deleted the
gamaj/MAYA-133671/allow_topo_handler_to_handle_untextured
branch
Allows quickly reducing a graph to only a surface for when the viewport is in "untextured" mode.