EMSUSD-1856 Add filtering search to the collection widget #4023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pierrebai-adsk
commented
Nov 29, 2024
pierrebai-adsk
commented
- Add a FilteredStringListModel class.
- Use that model in the collection string list widgets.
- Add a text edit widget to enter the search text
- Connect the search changed signal to the filtered model.
- Add a button to clear the search filter.
- Add a flag on the filtered model to remember if it was entirely filtered out.
- Properly re-filter the model when a new list of text is given.
- Moved the filtered view in its own file.
- Give the resizable lists a sensible default size.
- Add a FilteredStringListModel class. - Use that model in the collection string list widgets. - Add a text edit widget to enter the search text - Connect the search changed signal to the filtered model. - Add a button to clear the search filter. - Add a flag on the filtered model to remember if it was entirely filtered out. - Properly re-filter the model when a new list of text is given. - Moved the filtered view in its own file. - Give the resizable lists a sensible default size.
pierrebai-adsk
commented
Nov 29, 2024
| @@ -127,6 +128,8 @@ def __init__( | |||
| self._widget: QWidget = None | |||
|
|
|||
| self.loadPersistentStorage() | |||
| if self._contentSize < 0 and defaultSize > 0: | |||
| self._contentSize = defaultSize | |||
There was a problem hiding this comment.
This avoids the lists to be very large by default. With the 80 passed in by the include/exclude panel, we get about 3 lines by default. Otherwise the lists a re way too big.
barbalt
approved these changes
Dec 2, 2024
pierrebai-adsk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.