Fix a bug where newer RenderMan shading nodes would be skipped when exporting Usd from Maya #3999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a bug where newer RenderMan shading nodes would be skipped when exporting Usd from Maya. There is a hardcoded map in maya-usd/lib/mayaUsd/fileio/shading/rfmShaderMap.h, and newer nodes that don't appear in that map were being skipped. I don't think the map is necessary for nodes that don't actually require a name mapping; it would be difficult to keep the list up to date. This change adds some code that falls back to assuming the rendermanForMaya writer is appropriate for nodes that would otherwise have been skipped.
|
This was my first time digging into this code, so there may be a better way to go about this. Or there may be some conditional necessary before going ahead and using the rendermanForMaya writer for unknown nodes. This change does fix the bug for my examples though. Let me know if you need advice on reproducing the problem. |
|
@katpet Thank you for submitting a pull-request, however before proceeding you will need to sign the Contributor License Agreement (CLA). Sean |
seando-adsk
added
the
do-not-merge-yet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug where newer RenderMan shading nodes would be skipped when exporting Usd from Maya. There is a hardcoded map in maya-usd/lib/mayaUsd/fileio/shading/rfmShaderMap.h, and newer nodes that don't appear in that map were being skipped. I don't think the map is necessary for nodes that don't actually require a name mapping; it would be difficult to keep the list up to date. This change adds some code that falls back to assuming the rendermanForMaya writer is appropriate for nodes that would otherwise have been skipped.