EMSUSD-626: As a layout artist, I'd like to toggle visibility of multiple prims #3417

seando-adsk · 2023-10-26T18:23:10Z

EMSUSD-626: As a layout artist, I'd like to toggle visibility of multiple prims

Added bulk edit menu support to base UsdContextOps class.
Override in MayaUsdContextOps to add Maya specific menu items.
Assign New Material / Assign Existing Material - both of these now only work on single prim if context item is not in selection.
Fix contextOps unit test because of spec change with material context menu items and selection.
Added unit test for bulk edit contextOps.

…iple prims * Added bulk edit menu support to base UsdContextOps class. * Override in MayaUsdContextOps to add Maya specific menu items. * Assign New Material / Assign Existing Material - both of these now only work on single prim if context item is not in selection. * Fix contextOps unit test because of spec change with material context menu items and selection. * Added unit test for bulk edit contextOps.

seando-adsk · 2023-10-26T18:24:14Z

lib/mayaUsd/ufe/UsdUndoMaterialCommands.cpp

@@ -422,7 +432,7 @@ void UsdUndoAssignNewMaterialCommand::execute()
            }
            // There might be some unassignable items in the selection list. Skip and warn.
            // We know there is at least one assignable item found in the ContextOps resolver.
-            if (!BindMaterialUndoableCommand::CompatiblePrim(parentItem)) {
+            if (!BindMaterialUndoableCommand::CompatiblePrim(parentItem) || isDefPrim(parentItem)) {


Nat wanted "Def" prims to have the same error (since they are incompatible).

seando-adsk · 2023-10-26T18:26:03Z

test/lib/ufe/testContextOps.py

+        # Select all three objects.
+        ufe.GlobalSelection.get().append(capsuleItem)
        ufe.GlobalSelection.get().append(cubeItem)
        ufe.GlobalSelection.get().append(sphereItem)

-        # Apply the new material on the unselected object. This object should also receive the new material binding,
-        # in addition to the two selected objects.
+        # Apply the new material one of the selected objects, so we are operating in
+        # bulk mode. All the selected objects should receive the new material binding.


As per design from Nat, I changed the behavior of "Assign New Material" to only work on selection (and not selection + context item).

seando-adsk · 2023-10-26T18:27:26Z

lib/usdUfe/ufe/UsdContextOps.cpp

-void UsdContextOps::setItem(const UsdSceneItem::Ptr& item) { fItem = item; }
+void UsdContextOps::setItem(const UsdSceneItem::Ptr& item)
+{
+    _item = item;


When setting the item, check for (and setup) the bulk edit.

seando-adsk · 2023-10-26T18:28:46Z

lib/usdUfe/ufe/UsdContextOps.cpp

 static constexpr char    kUSDDeactivatePrimLabel[] = "Deactivate Prim";
 static constexpr char    kUSDToggleInstanceableStateItem[] = "Toggle Instanceable State";
-static constexpr char    kUSDMarkAsInstancebaleLabel[] = "Mark as Instanceable";


Fixed typo in kXXXLabel variable name.

seando-adsk · 2023-10-26T18:29:48Z

lib/usdUfe/ufe/UsdContextOps.cpp

@@ -417,6 +465,61 @@ Ufe::ContextOps::Items UsdContextOps::getItems(const Ufe::ContextOps::ItemPath&
    return items;
 }

+// Adds the special Bulk Edit header as the first item.
+void UsdContextOps::addBulkEditHeader(Ufe::ContextOps::Items& items) const


Helper function so that it can be called from LookdevX plugin which also overrides contextOps and sometimes uses only their context menu (not calling ours).

seando-adsk · 2023-10-26T18:32:35Z

lib/mayaUsd/ufe/MayaUsdContextOps.cpp

+}
+#endif
+
+inline bool sceneItemSupportsShading(const Ufe::SceneItem::Ptr& sceneItem)


This one was already here, I just made it inline and removed if (now just single return line).

seando-adsk · 2023-10-26T18:33:16Z

lib/usdUfe/ufe/UsdContextOps.h

+    UsdSceneItem::Ptr _item;
+    bool              _isAGatewayType { false };


Fixed member var names according to coding standard.

seando-adsk · 2023-10-26T18:34:27Z

lib/mayaUsd/ufe/MayaUsdContextOps.cpp

+        // In single context item mode, only assign material to the context item.
+        return std::make_shared<InsertChildAndSelectCommand>(
+            UsdUndoAssignNewMaterialCommand::create(_item, itemPath[2]));


According to new spec from Nat, only apply this command to single context item (not plus selection). New bulk menu is for selection.

seando-adsk · 2023-10-26T18:34:33Z

lib/mayaUsd/ufe/MayaUsdContextOps.cpp

+        // In single context item mode, only assign material to the context item.
+        return std::make_shared<BindMaterialUndoableCommand>(_item->path(), SdfPath(itemPath[2]));


According to new spec from Nat, only apply this command to single context item (not plus selection). New bulk menu is for selection.

seando-adsk · 2023-10-26T18:35:18Z

lib/mayaUsd/ufe/MayaUsdContextOps.cpp

+#ifdef DEBUG
+    auto DEBUG_OUTPUT = [&compositeCmd](const Ufe::Selection& bulkItems) {
+        TF_STATUS(
+            "Performing bulk edit on %d prims (%d selected)",
+            compositeCmd->cmdsList().size(),
+            bulkItems.size());
+    };
+#else
+#define DEBUG_OUTPUT(x) (void)0
+#endif


Helpful debugging output to show how many bulk items there were and how many the menu action was applied to. Only outputs in debug builds.

…iple prims * clang-format

…iple prims * Fix compiler errors for prior Maya builds.

…iple prims * Fix compiler error and unit test.

…iple prims * Fix compiler error (linux/osx) - related to unused ufe v4 function.

seando-adsk commented Oct 26, 2023

View reviewed changes

seando-adsk requested a review from AramAzhari-adsk October 26, 2023 18:35

AramAzhari-adsk previously approved these changes Oct 26, 2023

View reviewed changes

seando-adsk assigned ecp-maya-devops-adsk Oct 27, 2023

seando-adsk added the ufe-usd Related to UFE-USD plugin in Maya-Usd label Oct 27, 2023

EMSUSD-626: As a layout artist, I'd like to toggle visibility of mult…

d466c98

…iple prims * clang-format

seando-adsk dismissed AramAzhari-adsk’s stale review via d466c98 October 27, 2023 17:00

seando-adsk assigned ecp-maya-devops-adsk and unassigned ecp-maya-devops-adsk Oct 27, 2023

AramAzhari-adsk previously approved these changes Oct 27, 2023

View reviewed changes

EMSUSD-626: As a layout artist, I'd like to toggle visibility of mult…

4d007e7

…iple prims * Fix compiler errors for prior Maya builds.

seando-adsk dismissed AramAzhari-adsk’s stale review via 4d007e7 October 27, 2023 18:12

seando-adsk assigned ecp-maya-devops-adsk and unassigned ecp-maya-devops-adsk Oct 27, 2023

AramAzhari-adsk previously approved these changes Oct 27, 2023

View reviewed changes

EMSUSD-626: As a layout artist, I'd like to toggle visibility of mult…

c191931

…iple prims * Fix compiler error and unit test.

seando-adsk dismissed AramAzhari-adsk’s stale review via c191931 October 27, 2023 19:44

seando-adsk assigned ecp-maya-devops-adsk and unassigned ecp-maya-devops-adsk Oct 27, 2023

AramAzhari-adsk previously approved these changes Oct 27, 2023

View reviewed changes

seando-adsk dismissed AramAzhari-adsk’s stale review via b3d83b2 October 31, 2023 14:29

seando-adsk assigned ecp-maya-devops-adsk and unassigned ecp-maya-devops-adsk Oct 31, 2023

AramAzhari-adsk previously approved these changes Oct 31, 2023

View reviewed changes

seando-adsk assigned ecp-maya-devops-adsk and unassigned ecp-maya-devops-adsk Oct 31, 2023

EMSUSD-626: As a layout artist, I'd like to toggle visibility of mult…

90ab805

…iple prims * Fix compiler error (linux/osx) - related to unused ufe v4 function.

seando-adsk dismissed AramAzhari-adsk’s stale review via 90ab805 October 31, 2023 17:08

seando-adsk force-pushed the donnels/EMSUSD-626/contextops_bulk_edit_support branch from b3d83b2 to 90ab805 Compare October 31, 2023 17:08

seando-adsk assigned ecp-maya-devops-adsk and unassigned ecp-maya-devops-adsk Oct 31, 2023

seando-adsk requested a review from AramAzhari-adsk October 31, 2023 18:28

AramAzhari-adsk approved these changes Oct 31, 2023

View reviewed changes

seando-adsk added the ready-for-merge Development process is finished, PR is ready for merge label Oct 31, 2023

seando-adsk merged commit 91959b1 into dev Oct 31, 2023
11 checks passed

seando-adsk deleted the donnels/EMSUSD-626/contextops_bulk_edit_support branch October 31, 2023 19:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

EMSUSD-626: As a layout artist, I'd like to toggle visibility of multiple prims #3417

EMSUSD-626: As a layout artist, I'd like to toggle visibility of multiple prims #3417

seando-adsk commented Oct 26, 2023

seando-adsk Oct 26, 2023

seando-adsk Oct 26, 2023

seando-adsk Oct 26, 2023

seando-adsk Oct 26, 2023

seando-adsk Oct 26, 2023

seando-adsk Oct 26, 2023

seando-adsk Oct 26, 2023

seando-adsk Oct 26, 2023

seando-adsk Oct 26, 2023

seando-adsk Oct 26, 2023

		// In single context item mode, only assign material to the context item.
		return std::make_shared<BindMaterialUndoableCommand>(_item->path(), SdfPath(itemPath[2]));

EMSUSD-626: As a layout artist, I'd like to toggle visibility of multiple prims #3417

EMSUSD-626: As a layout artist, I'd like to toggle visibility of multiple prims #3417

Conversation

seando-adsk commented Oct 26, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment