EMSUSD-644 - As a user, I'd like to add a relative payload/ref on a anonymous layer #3370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const PostponedRelativePaths::iterator& layerEntry, | ||
| const std::string& anchorDirStr) | ||
| { | ||
| for (const SdfPrimSpecHandle& child : primSpec->GetNameChildren()) { |
There was a problem hiding this comment.
Question: does this only return child prim spec that are in the same layer or can it return prim spec from other layers? What about references? Can it traverse references?
IDK, for example, what happens if the user adds a payload to a prim that only lives in a reference? Will it be found?
There was a problem hiding this comment.
Mmm, we're only trying to update things that are inside the layer that just got saved. So I guess my question is irrelevant.
pierrebai-adsk
approved these changes
Oct 6, 2023
vlasovi
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixes [EMSUSD-634] - Error when attempting to add a Maya Reference.