EMSUSD-59 make error messages more clear #3310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierrebai-adsk
added
enhancement
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-59/error-in-success
branch
from
c10ea52 to
8b8f5ad
Compare
Some error checking logging was confusing for the user. Some failures were reported as the cryptic: "Failed verification: ' result == MStatus::kSuccess '". This leads users to think we are reporting a success. (Technically we were reporting failure to succeed, but the message was worded confusingly.) Change those failure verification messages to use explicit warning messages instead. This provides clearer failure diagnostics.
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-59/error-in-success
branch
from
9214145 to
0dc364c
Compare
vlasovi
approved these changes
Sep 6, 2023
pierrebai-adsk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some error checking logging was confusing for the user. Some failures were reported as the cryptic: "Failed verification: ' result == MStatus::kSuccess '". This leads users to think we are reporting a success. (Technically we were reporting failure to succeed, but the message was worded confusingly.)
Change those failure verification messages to use explicit warning messages instead. This provides clearer failure diagnostics.