LOOKDEVX-1847 - Fix broken normal maps #3307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous work in PR #3295 broke normal mapping by pessimistically using the arbitrary tangent generator. Bring back the texcoord tangents if we detect that implicit texcoords are going to be used.
| { | ||
| uniform token info:id = "ND_image_vector3" | ||
| asset inputs:file = @textures/mesh_wire_norm.png@ | ||
| string inputs:filtertype = "closest" |
There was a problem hiding this comment.
No geompropvalue node, so will default to "st"
| def Shader "geompropvalue1" | ||
| { | ||
| uniform token info:id = "ND_geompropvalue_vector2" | ||
| string inputs:geomprop = "st1" |
There was a problem hiding this comment.
In this case, since this is the geompropreader connected to the normalmap image, this will be also connected to the auto-added texcoordtangents node.
| } | ||
| } | ||
| ) | ||
| texCoord2f[] primvars:st1 = [(1.5051357, 0.5019881), (0.4980119, 1.5051357), (0.5019881, -0.50513566), (-0.50513566, 0.4980119)] ( |
There was a problem hiding this comment.
Using UVs tilted 45 and 135 degrees to make sure we are not using the arbitrary tangent generator.
vlasovi
approved these changes
Sep 5, 2023
JGamache-autodesk
added
the
ready-for-merge
|
@seando-adsk Ready for merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous work in PR #3295 broke normal mapping by pessimistically using the arbitrary tangent generator. Bring back the texcoord tangents if we detect that implicit texcoords are going to be used.