Adding unit test for AETemplate #3297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seando-adsk
commented
Aug 24, 2023
Comment on lines
+47
to
+68
| def searchForMayaControl(self, controlOrLayout, mayaControlCmd, labelToFind): | ||
| '''Helper function to search for a Maya control or layout with the label | ||
| matching the input string <p labelToFind>. The type of the control being | ||
| searched for is also given as input <p mayaControlCmd>. | ||
| ''' | ||
| if mayaControlCmd(controlOrLayout, exists=True): | ||
| if mayaControlCmd(controlOrLayout, q=True, label=True) == labelToFind: | ||
| return controlOrLayout | ||
|
|
||
| if controlOrLayout: | ||
| childrenOfLayout = cmds.layout(controlOrLayout, q=True, ca=True) | ||
| if childrenOfLayout: | ||
| for child in childrenOfLayout: | ||
| child = controlOrLayout + '|' + child | ||
| if cmds.layout(child, exists=True): | ||
| foundControl = self.searchForMayaControl(child, mayaControlCmd, labelToFind) | ||
| if foundControl: | ||
| return foundControl | ||
| elif mayaControlCmd(child, exists=True): | ||
| if mayaControlCmd(child, q=True, label=True) == labelToFind: | ||
| return child | ||
| return None |
There was a problem hiding this comment.
This function searched thru the layouts in the AE for either a layout (in this case we are searching for frame layout which is used for each section) with a specific name or a control (of a certain type) with a label equal to input name.
seando-adsk
commented
Aug 24, 2023
Comment on lines
+106
to
+109
| # We should have a frameLayout called 'Capsule' in the template. | ||
| # If there is a scripting error in the template, this layout will be missing. | ||
| frameLayout = self.searchForMayaControl(startLayout, cmds.frameLayout, 'Capsule') | ||
| self.assertIsNotNone(frameLayout, 'Could not find Capsule frameLayout') |
There was a problem hiding this comment.
Example: there should exist a section called "Capsule"
seando-adsk
commented
Aug 24, 2023
Comment on lines
111
to
115
| # We should also have float slider controls for 'Height' & 'Radius'. | ||
| heightControl = self.searchForMayaControl(frameLayout, cmds.floatSliderGrp, 'Height') | ||
| self.assertIsNotNone(heightControl, 'Could not find Capsule Height control') | ||
| radiusControl = self.searchForMayaControl(frameLayout, cmds.floatSliderGrp, 'Radius') | ||
| self.assertIsNotNone(radiusControl, 'Could not find Capsule Radius control') |
There was a problem hiding this comment.
And that Capsule section should have attributes for height/radius.
AramAzhari-adsk
previously approved these changes
Aug 31, 2023
seando-adsk
added
the
do-not-merge-yet
seando-adsk
removed
the
do-not-merge-yet
|
@AramAzhari-adsk Sorry had to make a specific fix for our Maya 2022 gold build (where the AE form layouts are not named the same way). |
AramAzhari-adsk
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New unit test that attempts to find when an error exists in the AE template which prevents it from being loaded correctly. When this happens the AE for USD prims will contain no frame sections, no metadata and all attributes are listed one after another.