Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(log): introduce async close #1503

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refactor(log): introduce async close #1503

wants to merge 2 commits into from

Conversation

DaniilRoman
Copy link

@DaniilRoman DaniilRoman commented Jul 3, 2024 •
edited
Loading

Closes the issue #1100

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@CLAassistant
Copy link

CLAassistant commented Jul 3, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@DaniilRoman DaniilRoman marked this pull request as ready for review July 3, 2024 19:51
superhx
superhx previously approved these changes Jul 4, 2024
View reviewed changes
@superhx superhx self-requested a review July 4, 2024 02:24
@daniel-y
Copy link
Contributor

daniel-y commented Jul 9, 2024

There are some compile errors, could you please have a look? @DaniilRoman

@DaniilRoman
Copy link
Author

There are some compile errors, could you please have a look? @DaniilRoman

ahh, apologies, I'm looking at it

@DaniilRoman
Copy link
Author

It compiles with following settings: Starting build with version 3.8.0-SNAPSHOT (commit id d44dcea0) using Gradle 8.7, Java 17 and Scala 2.13.14
Tests where LocalLog is used pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SCNieh SCNieh Awaiting requested review from SCNieh SCNieh is a code owner

@ShadowySpirits ShadowySpirits Awaiting requested review from ShadowySpirits ShadowySpirits is a code owner

@Chillax-0v0 Chillax-0v0 Awaiting requested review from Chillax-0v0 Chillax-0v0 is a code owner

@superhx superhx Awaiting requested review from superhx superhx is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@DaniilRoman @CLAassistant @daniel-y @superhx