feat(issues1101): argparse4j downgr… #1184
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Shuimo03
changed the title
daniel-y
reviewed
Apr 27, 2024
| .build() | ||
| .defaultHelp(true) | ||
| .description("The Trogdor agent client."); | ||
| .newArgumentParser("trogdor-agent-client") |
There was a problem hiding this comment.
There are many modifications since we upgraded argparse4j to 0.9 which brings us more effort to merge kafka upstream. Could you please search .newFor() and revert all the modifications?
There was a problem hiding this comment.
Also please pay attention to the failed github action that may be helpful to find all the modifications. Thanks for your contributions.
…rse4j # Conflicts: # trogdor/src/main/java/org/apache/kafka/trogdor/agent/AgentClient.java
|
Please keep the old code format to avoid merge conflict when merging from kafka/trunk. You could check kafka_3_7_0...main to downgrade argparse4j |
|
ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issues: #1101