CRAN fixes, comments

AustralianAntarcticDivision · Jul 19, 2016 · 9b56d22 · 9b56d22
1 parent f7a5182
commit 9b56d22
Show file tree

Hide file tree

Showing 4 changed files with 28 additions and 25 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -9,5 +9,5 @@ License: CC0
 RoxygenNote: 5.0.1
 Suggests: testthat,
     covr
-BugReports: https://github.com/ AustralianAntarcticDivision/bgmfiles/issues/
+BugReports: https://github.com/AustralianAntarcticDivision/bgmfiles/issues/
 URL: https://github.com/AustralianAntarcticDivision/bgmfiles/, http://atlantis.cmar.csiro.au/
diff --git a/README.Rmd b/README.Rmd
@@ -59,11 +59,8 @@ print(basename(afiles))
 ```
 This package exists as a data package to install example files, the function `bgmfiles` is ridiculously simple and simply runs file finding functions: 
 
-```{r}
-files <- list.files(system.file("extdata", package = "bgmfiles"), pattern = NULL, full.names = TRUE, recursive = TRUE)
-
-print(basename(files))
-
+```{r, eval=FALSE}
+list.files(system.file("extdata", package = "bgmfiles"), pattern = NULL, full.names = TRUE, recursive = TRUE)
 ```
 
 We don't need to load or attach the package to find these files, but using the installation mechanism is very convenient for R use.  

diff --git a/README.md b/README.md
@@ -6,7 +6,7 @@ BGM files for Atlantis
 
 A raw-data package with example .bgm files (box geometry model) for Atlantis ecosystem model.
 
-Atlantis is a deterministic, biogeochemical, whole-of-ecosystem model. <http://atlantis.cmar.csiro.au/>.
+Atlantis is a deterministic, biogeochemical, whole-of-ecosystem model: <http://atlantis.cmar.csiro.au/>.
 
 **PLEASE NOTE:** this is not an official source of BGM for use in Atlantis.
 
@@ -58,21 +58,7 @@ print(basename(afiles))
 This package exists as a data package to install example files, the function `bgmfiles` is ridiculously simple and simply runs file finding functions:
 
 ``` r
-files <- list.files(system.file("extdata", package = "bgmfiles"), pattern = NULL, full.names = TRUE, recursive = TRUE)
-
-print(basename(files))
-#>  [1] "AEEC_poly_projETRS89_LAEA_snapped0p002.bgm"
-#>  [2] "ams71.bgm"                                 
-#>  [3] "antarctica_28.bgm"                         
-#>  [4] "antarctica_99.bgm"                         
-#>  [5] "CalCurrentV3_utm.bgm"                      
-#>  [6] "GOM_BGM.bgm"                               
-#>  [7] "Guam_utm1.bgm"                             
-#>  [8] "JFRE_ll.bgm"                               
-#>  [9] "JFRE_xy.bgm"                               
-#> [10] "NGOM.bgm"                                  
-#> [11] "Nordic02.bgm"                              
-#> [12] "VMPA_setas.bgm"
+list.files(system.file("extdata", package = "bgmfiles"), pattern = NULL, full.names = TRUE, recursive = TRUE)
 ```
 
 We don't need to load or attach the package to find these files, but using the installation mechanism is very convenient for R use.

diff --git a/cran-comments.md b/cran-comments.md
@@ -7,9 +7,29 @@
 
 0 errors | 0 warnings | 1 note
 
-* This is a new release.
+>  Maintainer: 'Michael D. Sumner <[email protected]>'
+>  
+>  New submission
+>  
+>  Possibly mis-spelled words in DESCRIPTION:
+>    BGM (2:16, 7:50)
+>    biogeochemical (7:124)
+>  
+>  Found the following (possibly) invalid URLs:
+>    URL: http://atlantis.cmar.csiro.au/
+>      From: README.md
+>      Status: 403
+>      Message: Forbidden
+>    URL: https://cran.r-project.org/package=bgmfiles
+>      From: README.md
+>      Status: 404
+>      Message: Not Found
+>      
 
-## Reverse dependencies
+* the mis-spelled instances are an initialism "BGM", expanded in the Description, and "biogeochemical" which is listed in the Oxford English dictionary 
 
-This is a new release, so there are no reverse dependencies.
+* the URLs are the main site for the Atlantis model, and the soon-to-exist address on CRAN
 
+Thank you, 
+
+Michael Sumner