Updated formatting to pass cs lint #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossgrambo-zz
approved these changes
Aug 26, 2019
There was a problem hiding this comment.
A little late but this looks good to me. @praecipula , what do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempted to resolve issue #45
Did not fix the error in
php-asana/tests/Asana/OAuthDispatcherTest.phpon line 19 that19 | ERROR | Each class must be in a file by itselfSince this would require adding files and possibly refactoring across files.
Added some variables for registering responses that matched existing style to meet line length requirements.
All other changes were formatting / style changes.
Hopefully people who follow the docs won't be /quite/ as confused as I was now that there isn't a whole screen-full of "errors".