Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPCS Lint Test in README Fail #45

Open
elwinmartin opened this issue Jan 6, 2018 · 2 comments
Open

PHPCS Lint Test in README Fail #45

elwinmartin opened this issue Jan 6, 2018 · 2 comments
Assignees

Comments

@elwinmartin
Copy link
Contributor

elwinmartin commented Jan 6, 2018

Hey, Asana team!

Minor irony but setting things up as shown in the README:

$ composer install
$ ./vendor/bin/phpunit --configuration tests/phpunit.xml
$ ./vendor/bin/phpcs --standard=PSR2 --extensions=php src tests

Actually produces a bunch of errors and warnings when PHPCS checks the test cases. These appear to be stylistic constraints like character counts, but I was wondering if I could submit a pull request with these things cleaned up.

I'm not sure if these were left in to demonstrate that the linter works or for some reason that escapes me, but I wouldn't be surprised if someone got confused and thought there were legitimate build errors because of these.

I understand this is a very low priority issue :)

Thanks!

Example Test Response:

FILE: .../php-asana/tests/Asana/Resources/WebhooksTest.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AND 1 WARNING(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
 37 | WARNING | Line exceeds 120 characters; contains 142 characters
 41 | ERROR   | Line indented incorrectly; expected at least 12 spaces, found
    |         | 10
--------------------------------------------------------------------------------
@praecipula praecipula self-assigned this Jan 16, 2018
@praecipula
Copy link
Contributor

Ha, that is ironic. My guess is that the person who last wrote tests (which, ahem, was me) forgot to run the lint tests before committing the changes. Feel free to submit a pull request if you feel so inspired and we'll pull it in!

@elwinmartin
Copy link
Contributor Author

@praecipula Finally got around to this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants