Adding twig template engine #28
Conversation
instead of processing the whole music collection within on mysql-fetch-loop smaller batchsizes gets processed. now there is NO(!!!) memory growth within importer-phase fileInfo() at all. Unfortunately the memory-usage of the previous importer-phase (fileStructure) is still a problematic starting point for fileInfo() further some massive code-cleanup regarding tag-processing had been done. TODO: make use of the new tag-processing where needed to remove duplicate code-mess TODO: refactoring fileStructure() in terms of memory consumption
to get rid of the code-mashup of php/html/js/css/mysql within single files a powerful lightweight template-engine had been added via composer. further the mess of index.php had been splitted into smaller files to /controller
a lot of O!MPD's javascript is build with php because of php variables are directly echoed into js variables. Now we have an additional route /index.php?action=jsConf for retrieving dynamic variables. so inside javascript those variables are easy usable via window.ompd.varName the twig template for this config object is located in templates/js/ompd-conf.js
|
Hi Artur, |
|
I've been thinking a lot about this (and composer too) and I have mixed feelings... From one hand the idea itself is OK and it'd be fine to built O!MPD using modern programming techniques. From the another hand I don't really see its significant advantages in this project. Rebuilding all code to use twig will take a lot of time and probably generate new problems. Time spent on this could be used for something else, eg. improving update procedure or adding new features (which is more enjoyable for me :)). I think that O!MPD should be somehow consistent - if it uses twig, it should use it everywhere, in all pages. Maybe it'd be better to tidy and clean up the code first - splitting I really appreciate your work and time you spent on making O!MPD better, but for now I'm not convinced to this idea. |
|
Hi Artur,
You are totally right that it makes no sense to roll O!MPD's code from bottom to top. But you really prefer to have (and produce more) unmaintainable code just to have it consistent? This sounds kinda strange Adding a template engine is a pretty tiny change that can reduce line-count of all the php functions from 10% up to 90%. From my point of view maintainability is far more important than consistency.
Of course this would be more elegant but there is not expicitly a technical need for it. Implementing a template based rendering can be limited to sections that have to be touched when developing new features or fixing bugs. The existing archticture/logic of O!MPD does not get changed by adding a template engine.
So getting rid of highly complex code parts that are very fragile is not a significant advantage for you? Seriously? I thought your plan was to continue your work on O!MPD in future!?
From my point of view its the opposite. Tons of code-duplication can be removed by proper reusing existing html snippets.
You are totally right. Tidy things up without having any changes is exactly what this pull request does
It's not the decision i wanted to hear but i am totally ok with it - O!MPD is your baby |
Hi Artur,
What do you think about adding a template engine to get rid of the code mashup (php/html/js/css within single files)? twig is a powerful template engine and is dead easy to use.
Instead of building horrible strings with php now you can simply call
i already included an example in this pull request for
index.php?action=viewRandomAlbum@see https://github.com/othmar52/OMPD/blob/twig/controller/viewRandomAlbum.php
@see https://github.com/othmar52/OMPD/blob/twig/templates/randomAlbum.htm
@see https://github.com/othmar52/OMPD/blob/twig/templates/partials/albumTile.htm
further i have splitted the unmaintainable file index.php which had more than 3000 lines of mashup into multiple files @see directory /controller/