Filter used to strip EXIF data from an image #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aboard is an adverb, whereas onboard is an adjective.
Fixes thumbor#808 in case an exception is thrown inside the engine.read() method the exception was either not caught properly (in case the THREADPOOL size is >0) or the result was not a tuple and the unpacking waits for more data while calling .result() (in case the THREADPOOL size is 0) the ThreadPoolWorker is using _WorkerItems() wrapping the Future() and using the Future().set_exception() method so the exception is thrown at the Future().result() call so it is similar to what happens when using the ThreadPoolWorker
Also add another test for thumbor#871
Fix thumbor#825. Please refer to the docs [1]. 1: http://www.tornadoweb.org/en/branch4.4/httpclient.html#tornado.httpclient.HTTPRequest
Improvement to gifsicle error handling
upscale() works together with (adaptive-)fit-in like no_upscale() together with either /WxH/ or (adaptive-)fit-in + filters:fill()
instead of an absolute timeout the curl http client also supports a download-speed timeout (if for X seconds the download speed is below Y bytes/s then abort) this is now being configurable but disabled by default (and ignored if the curl client isn't used)
added new timeout setting if using curl http client
adding new filter `upscale()` (fixes thumbor#726 and thumbor#856)
In de1d96f, because of the API to engines, the only way to preserve the EXIF data for storage is to change the global (effective singleton) configuration. Unfortunately, if another request is doing an Engine.read at the same time with the same configuration, it suddenly has its configuration forced by this block. We change this instead to have quasi copy-on-write semantics.
just drop of python 2.6, which is already dropped by thumbor
Allow pillow 4 since there were no BC breaks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This filter removes any Exif information in the resulting image.
This is useful if you have set the configuration PRESERVE_EXIF_INFO = True but still wish to overwrite this behaviour in some cases (e.g. for image icons)