Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resynchronizes the
src/rp2040/
directory with the latest Klipper code. Notably, this adds support for rp2350 chips to Katapult.This is a fairly large change mostly because of subtle differences between the previous Katapult rp2040 code and the Klipper rp2040 code. Notably:
scripts/uf2_append_boot_signature.py
is still present, but it can't be enabled from "make menuconfig". I'm not sure what this code does, so I don't know how to test it (in particular on the rp2350 chips).Note "enter bootloader on rapid double click of reset" support does not work on the rp2350 chips. It seems like these chips disable power to the SRAM0 and SRAM1 blocks when the RUN pin is pulled low, and thus codes written to the "bootup_code" address do not persist upon tapping the reset button. These memory based codes do persist across a normal armcm software reset, so entering the bootloader and starting the application do work. The rp2040 continues to support "entry via double click reset".
It may be possible to support "enter via reset double click" on the rp2350 by reconfiguring the chip power registers. It may also be possible to support it using the chip's own
CHIP_RESET.DOUBLE_TAP
mechanism. In either case, more investigation will be needed; it can be added in a follow up PR.I've performed basic tests with this code on an rp2350 chip in USBSERIAL mode. I have also verified the code continues to run on an rp2040 chip (also tested in USBSERIAL mode).
@sh83 - FYI.
-Kevin