Fix false positive result where test passed even though gcc failed with error #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you point me to an example of where this is happening and/or how I can reproduce it locally? Also, I'm not clear on how the change to |
hlovdal
force-pushed
the
failure_handling.m
branch
from
7cb55a6
to
f1395aa
Compare
ianfixes
reviewed
Dec 31, 2022
| end.flatten | ||
| (additional_libraries + recursive).uniq | ||
| recursive.uniq | ||
| end |
There was a problem hiding this comment.
Do you have a test case or some performance metric that relates to this change? Just trying to figure out whether this is an improved implementation or a bugfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even if gcc failed with errors for some of the files compiled for unit test, the test would still be reported as successful. This is fixed by properly increasing
@failure_count.Also an additional fix for the result calculation for
all_arduino_library_dependencies!. It is a long time since I made that commit so I do not exactly remember the details but reading it now accumulating with[n]inside themapsection looks more correct.Updates to CHANGELOG.md will trigger conflicts for this branch (
failure_handling.m, rebased on top ofmaster) when #338 is completed (or if this is done first, then #338 will get conflicts).There is an alternative branch
failure_handlingapplied in series with other branches that does not have those conflicts when #338 is completed. Let me know if you rather want that one merged (later).