Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check that INS_HNTCn_REF is non-zero for ESC,RPM or FFT notches #28786

Open
tridge opened this issue Nov 30, 2024 · 0 comments
Open

check that INS_HNTCn_REF is non-zero for ESC,RPM or FFT notches #28786

tridge opened this issue Nov 30, 2024 · 0 comments
Assignees

Comments

@tridge
Copy link
Contributor

tridge commented Nov 30, 2024

it is quite common when users setup notch filters with ESC or FFT notches to forget to set INS_HNTCn_REF to a non-zero value. When set to zero it becomes a single fixed notch which is almost certainly not what they want.
We either need an arming check, or we need to make the is_zero(ref) check in AP_Vehicle::update_dynamic_notch() only apply to the throttle based notch
The ref is only used for:

  • throttle based notch
  • RPM notch (as scale factor)
  • fallback to throttle notch for ESC notch (edge case)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants