Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some audio backend cleanup / refactor #943

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Some audio backend cleanup / refactor #943

wants to merge 5 commits into from

Commits on Oct 21, 2024

  1. typo: Fix peridod - also in lua set_peridod_size

    @kiilerix
    kiilerix committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    29e71b5 View commit details
    Browse the repository at this point in the history

  2. audio_backend: Get name of standard device directly, without unnecess… 

    …ary enum StandardDeviceName

The StandardDeviceName enum was misleadingly *not* the name - the name
only came from get_standard_device_name.

Instead, simplify things, and just use two different trivial getters.
    @kiilerix
    kiilerix committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    a3ac3c7 View commit details
    Browse the repository at this point in the history

  3. audio_backend: Merge is_realtime() into client_real_time_priority() 

    The description of is_realtime() did not match its actual use. And
client_real_time_priority() did not have any description. It was
hard to come up with good descriptions of what they actually did.

Most backends returned true from is_realtime(), but every one except
JACK used the default implementation of client_real_time_priority() that
returned 0 ... which is exactly the same as when is_realtime() returns
false. Just merge them and keep it simple.
    @kiilerix
    kiilerix committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    9c0c4f5 View commit details
    Browse the repository at this point in the history

  4. audio_backend: Rename instantiate() parameter arg2 to session_id 

    The thing called backend_client_name defaulted to lowercase PROGRAM_NAME
and could be controlled with:

    -c, --name <name>           Use a specific backend client name, default is ardour

This value was *only* used for set_backend arg2 which only is used for
jack, where it was called session_uuid and passed to jack_client_open as
"a SessionID Token this allows the sessionmanager to identify the client
again" because JackSessionID.

It is certainly misleading to call it a uuid. It also doesn't seem
helpful to call it "client name" when the documentation calls it
"session id". And mostly: jack_client_open calls its *first* argument
"client_name" and it comes from argv1.

To clear things up, consistently call it something with "session id".
And it is not helpful to use a generic arg2 naming.
    @kiilerix
    kiilerix committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    710bd07 View commit details
    Browse the repository at this point in the history

  5. audio_backend: Rename instantiate() parameter arg1 to client_name 

    This parameter is consistently used to name the audio backend instance
and how it appear as client of the sound server. Just name it
`client_name`, consistent with the name of the jack_client_open
parameter it is passed to .
    @kiilerix
    kiilerix committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    79e99c1 View commit details
    Browse the repository at this point in the history