Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Community App Store (Sourcery refactored) #172

Closed
wants to merge 1 commit into from

Conversation

sourcery-ai[bot]
Copy link

@sourcery-ai sourcery-ai bot commented Jun 22, 2022

Pull Request #69 refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the app_store branch, then run:

git fetch origin sourcery/app_store
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

@sourcery-ai sourcery-ai bot requested a review from Archmonger June 22, 2022 02:26
@@ -39,33 +39,26 @@ async def set_viewport():
elif state._viewport_secondary is state._viewport_intent:
state._viewport_selector = ViewportSelector.secondary

# Replace the selected viewport
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function homepage.set_viewport refactored with the following changes:

This removes the following comments ( why? ):

# Replace the oldest viewport
# Replace the selected viewport
# Automatically determine what viewport to use

@sourcery-ai sourcery-ai bot closed this Jun 22, 2022
@sourcery-ai sourcery-ai bot deleted the sourcery/app_store branch June 22, 2022 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants