Add mediatypes #127
Add mediatypes #127
Conversation
|
@glenrobson @digitaldogsbody Ok, I've added a number of media types, and added some tests as well. |
There was a problem hiding this comment.
Looks good to me - my only thinking would be that it might be nice if the options in the choice block were from "most desirable" to "least desirable" (although as long as what we think should be the default is first so that clients that pick the first option by default get something usable, this is not hugely important), so maybe we could reverse the order of the new MP3 types so the higher bitrate ones are at the start of the list behind VBR. This is also very much something we can address later after the service is launched :)
|
That makes solid sense to me, and an easy fix, I will make that change and push shortly! |
No description provided.