Add logic for etree and 24bit flac #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Draft PR to add in logic to (hopefully) fix #123 |
|
@digitaldogsbody, if you get a chance, would love a gut-check on whether I'm competently adjusted the logic in the resolver to account for some of the file types I encountered when trying to get some of the Live Music Archive stuff on IA working with our setup. This adds a few filetypes, but there's still the open question in #125 about whether we want to be comprehensive or not. |
|
Changes look good to me :) |
digitaldogsbody
approved these changes
Jul 20, 2023
|
Could we add a test? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.