Allow CompressedTextProperty to be None #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ying properties with a limited set of values (aka choices)
…subclasses for it -- Thanks to Nick Johnson for the suggestions -- Also fix a bug in the doctest and update it
…iceProperty => easier to get choice->index mapping than c2i() -- Thanks to Nick Johnson for this suggestion too :)
…tributes which map choices to their int representation
…essedTextProperty -- now both byte strings and unicode text can be stored in compressed form
-- values are stored in the naive datetime format, but when retrieved they will be adjusted to Pacific time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nick, please consider cherry-picking commit 9eebd42 so that CompressedTextProperty is permitted to be None.
(The pull request is for all 12 commits because I don't see how I can for just the cherry-picking of the one; please ignore the others. I think to cherry-pick the commit you'll need to add my fork as a remote.)