Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR with multiple changes and improvements grouped together #343

Merged
merged 102 commits into from
Jul 2, 2024

Conversation

joiskash
Copy link
Collaborator

@joiskash joiskash commented Apr 16, 2024

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #192 #341 #304 #310 #311 #226

Description
Other changes that are included in this PR

  1. Priority for commands
  2. H264 reverse playback
  3. MMQ pacemaker
  4. Race conditions fixed between MMQ and decoder
  5. Abstract control module for pipeline control
  6. Thumbnail generator added

Alternative(s) considered

Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type

Type Choose one: (Bug fix and Feature)

Screenshots (if applicable)

Checklist

  • I have read the Contribution Guidelines
  • I have written Unit Tests
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach

@joiskash joiskash mentioned this pull request Apr 16, 2024
3 tasks
Copy link
Collaborator Author

@joiskash joiskash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review

base/include/Command.h Outdated Show resolved Hide resolved
base/include/stdafx.h Show resolved Hide resolved
data/app_ui.glade Outdated Show resolved Hide resolved
base/src/View.cpp Outdated Show resolved Hide resolved
base/src/MultimediaQueueXform.cpp Outdated Show resolved Hide resolved
base/src/MultimediaQueueXform.cpp Outdated Show resolved Hide resolved
base/src/MultimediaQueueXform.cpp Show resolved Hide resolved
base/src/MultimediaQueueXform.cpp Outdated Show resolved Hide resolved
base/src/MultimediaQueueXform.cpp Outdated Show resolved Hide resolved
base/src/MultimediaQueueXform.cpp Outdated Show resolved Hide resolved
base/src/NvEglRenderer.cpp Show resolved Hide resolved
base/src/NvEglRenderer.cpp Show resolved Hide resolved
base/src/NvEglRenderer.cpp Show resolved Hide resolved
base/include/ThumbnailListGenerator.h Show resolved Hide resolved
base/include/BoundBuffer.h Outdated Show resolved Hide resolved
base/src/Background.cpp Outdated Show resolved Hide resolved
base/src/Model.cpp Outdated Show resolved Hide resolved
base/src/Module.cpp Show resolved Hide resolved
base/src/Module.cpp Outdated Show resolved Hide resolved
base/src/Mp4WriterSink.cpp Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Jun 28, 2024

Test Results Linux_ARM64

  1 files    1 suites   11m 2s ⏱️
431 tests 259 ✅ 172 💤 0 ❌
259 runs   87 ✅ 172 💤 0 ❌

Results for commit fd4ace6.

♻️ This comment has been updated with latest results.

mraduldubey
mraduldubey previously approved these changes Jun 28, 2024
@mraduldubey mraduldubey merged commit 53157e2 into main Jul 2, 2024
17 of 19 checks passed
@mraduldubey mraduldubey deleted the ApraNVR_CommonBuild branch July 2, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GtkGl Renderer
8 participants