Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support publish view #5576

Merged
merged 160 commits into from
Jul 8, 2024
Merged

Conversation

qinluhe
Copy link
Collaborator

@qinluhe qinluhe commented Jun 19, 2024

Feature Preview

  • The Interface is for the client to get binary data
  • The event for publishing view and its child views
  • The event for unpublishing views
  • The event for getting publish info
  • The event for setting publish namespace
  • The event for getting publish namespace

PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

@qinluhe qinluhe force-pushed the feat/support-get-encoded-collab-event branch 4 times, most recently from cf8f7ea to dbcf8ba Compare June 21, 2024 08:19
@qinluhe qinluhe changed the title feat: support a event for getting encoded collab of document feat: support publish view Jun 21, 2024
Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 52.36994% with 412 lines in your changes missing coverage. Please review.

Project coverage is 84.08%. Comparing base (c122f0a) to head (8488334).
Report is 39 commits behind head on main.

Files Patch % Lines
...owy_web_app/src/components/publish/header/utils.ts 0.00% 55 Missing ⚠️
...pflowy_web_app/src/application/publish/context.tsx 3.77% 51 Missing ⚠️
..._app/src/application/services/js-services/index.ts 78.78% 28 Missing ⚠️
...rc/components/publish/header/PublishViewHeader.tsx 4.54% 21 Missing ⚠️
...tor/components/blocks/link-preview/LinkPreview.tsx 5.26% 18 Missing ⚠️
..._app/src/components/publish/header/MoreActions.tsx 0.00% 18 Missing ⚠️
...eb_app/src/components/publish/header/SpaceIcon.tsx 5.26% 18 Missing ⚠️
...app/src/components/publish/outline/OutlineItem.tsx 0.00% 18 Missing ⚠️
...rc/application/services/js-services/cache/index.ts 90.00% 15 Missing ⚠️
...p/src/components/publish/header/BreadcrumbItem.tsx 0.00% 15 Missing ⚠️
... and 34 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5576      +/-   ##
==========================================
- Coverage   86.74%   84.08%   -2.66%     
==========================================
  Files         217      211       -6     
  Lines        5032     5115      +83     
  Branches      831      850      +19     
==========================================
- Hits         4365     4301      -64     
- Misses        561      722     +161     
+ Partials      106       92      -14     
Flag Coverage Δ
appflowy_web_app 84.08% <52.36%> (-2.66%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qinluhe qinluhe force-pushed the feat/support-get-encoded-collab-event branch from dbcf8ba to 77a53ef Compare June 21, 2024 10:46
@qinluhe qinluhe force-pushed the feat/support-get-encoded-collab-event branch from f2991be to 2557d90 Compare June 26, 2024 09:05
qinluhe and others added 28 commits July 4, 2024 23:01
@LucasXu0 LucasXu0 merged commit 23c67bc into main Jul 8, 2024
18 checks passed
@LucasXu0 LucasXu0 deleted the feat/support-get-encoded-collab-event branch July 8, 2024 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants