fix: close client on bloc close

AppFlowy-IO · Mar 2, 2024 · 6053ea6 · 6053ea6
1 parent 39fe3f3
commit 6053ea6
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 2 deletions.
diff --git a/frontend/appflowy_flutter/lib/user/application/github/github_service.dart b/frontend/appflowy_flutter/lib/user/application/github/github_service.dart
@@ -14,6 +14,10 @@ abstract class IGitHubService {
   ///
   /// Returns [GitHubReleaseInfo] if the request is successful, otherwise returns null.
   Future<GitHubReleaseInfo?> checkLatestGitHubRelease();
+
+  /// Disposes of any resources used by the service.
+  ///
+  void dispose();
 }
 
 @freezed
@@ -81,4 +85,9 @@ class GitHubService implements IGitHubService {
 
     return null;
   }
+
+  @override
+  void dispose() {
+    _client.close();
+  }
 }
diff --git a/...n/update_checker/update_checker_bloc.dart → ...version_checker/version_checker_bloc.dart b/...n/update_checker/update_checker_bloc.dart → ...version_checker/version_checker_bloc.dart
@@ -5,7 +5,7 @@ import 'package:bloc/bloc.dart';
 import 'package:freezed_annotation/freezed_annotation.dart';
 import 'package:package_info_plus/package_info_plus.dart';
 
-part 'update_checker_bloc.freezed.dart';
+part 'version_checker_bloc.freezed.dart';
 
 class VersionCheckerBloc
     extends Bloc<VersionCheckerEvent, VersionCheckerState> {
@@ -39,6 +39,12 @@ class VersionCheckerBloc
   }
 
   late final IGitHubService _gitHubService;
+
+  @override
+  Future<void> close() async {
+    _gitHubService.dispose();
+    return super.close();
+  }
 }
 
 @freezed

diff --git a/...end/appflowy_flutter/lib/workspace/presentation/widgets/float_bubble/question_bubble.dart b/...end/appflowy_flutter/lib/workspace/presentation/widgets/float_bubble/question_bubble.dart
@@ -5,7 +5,7 @@ import 'package:appflowy/generated/flowy_svgs.g.dart';
 import 'package:appflowy/generated/locale_keys.g.dart';
 import 'package:appflowy/startup/startup.dart';
 import 'package:appflowy/startup/tasks/rust_sdk.dart';
-import 'package:appflowy/workspace/application/update_checker/update_checker_bloc.dart';
+import 'package:appflowy/workspace/application/version_checker/version_checker_bloc.dart';
 import 'package:appflowy/workspace/presentation/home/toast.dart';
 import 'package:appflowy/workspace/presentation/widgets/pop_up_action.dart';
 import 'package:appflowy_popover/appflowy_popover.dart';