Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] S3 collab cache #1028

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

[WIP] S3 collab cache #1028

wants to merge 12 commits into from

Conversation

Horusiath
Copy link
Collaborator

@Horusiath Horusiath commented Nov 28, 2024 •
edited
Loading

This PR reimplements DiskCache to store encoded collabs in S3-compatible storage rather than in Postgres. Postgres is used only as a fallback for compatibility with an existing storage model.

TODOs:

  • Use S3 for collab snapshot data as well.
  • We need to decide if we really want to store EncodedCollab format in S3. IMO it's useless - it's heavily reliant on bincode (which is not version tolerant) and all of the fields (namely: state_vector) can be resolved from doc_state directly instead. We could keep a straight up yrs Doc state instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Horusiath