Fix CA1062 warning. Composite(Draft)

src/Polly/Bulkhead/AsyncBulkheadPolicy.cs

@@ -1,6 +1,9 @@
 #nullable enable
+
 namespace Polly.Bulkhead;
 
+#pragma warning disable CA1062 // Validate arguments of public methods // Temporary stub
+
 /// <summary>
 /// A bulkhead-isolation policy which can be applied to delegates.
 /// </summary>

src/Polly/Bulkhead/BulkheadPolicy.cs

@@ -1,6 +1,9 @@
 #nullable enable
+
 namespace Polly.Bulkhead;
 
+#pragma warning disable CA1062 // Validate arguments of public methods // Temporary stub
+
 /// <summary>
 /// A bulkhead-isolation policy which can be applied to delegates.
 /// </summary>

src/Polly/Caching/AsyncCachePolicy.cs

@@ -1,6 +1,8 @@
 #nullable enable
 namespace Polly.Caching;
 
+#pragma warning disable CA1062 // Validate arguments of public methods
+
 /// <summary>
 /// A cache policy that can be applied to the results of delegate executions.
 /// </summary>
@@ -119,4 +121,3 @@ protected override Task<TResult> ImplementationAsync(Func<Context, CancellationT
             _onCachePutError,
             cancellationToken);
 }
-

src/Polly/Caching/AsyncCacheSyntax.cs

@@ -45,8 +45,19 @@
     /// <returns>The policy instance.</returns>
     /// <exception cref="ArgumentNullException">Thrown when <paramref name="cacheProvider"/> is <see langword="null"/>.</exception>
     /// <exception cref="ArgumentNullException">Thrown when <paramref name="cacheKeyStrategy"/> is <see langword="null"/>.</exception>
-    public static AsyncCachePolicy CacheAsync(IAsyncCacheProvider cacheProvider, TimeSpan ttl, ICacheKeyStrategy cacheKeyStrategy, Action<Context, string, Exception>? onCacheError = null) =>
-        CacheAsync(cacheProvider, new RelativeTtl(ttl), cacheKeyStrategy.GetCacheKey, onCacheError);
+    public static AsyncCachePolicy CacheAsync(
+        IAsyncCacheProvider cacheProvider,
+        TimeSpan ttl,
+        ICacheKeyStrategy cacheKeyStrategy,
+        Action<Context, string, Exception>? onCacheError = null)
+    {
+        if (cacheKeyStrategy is null)
+        {
+            throw new ArgumentNullException(nameof(cacheKeyStrategy));
+        }
+
+        return CacheAsync(cacheProvider, new RelativeTtl(ttl), cacheKeyStrategy.GetCacheKey, onCacheError);
+    }
 
     /// <summary>
     /// <para>Builds an <see cref="AsyncPolicy" /> that will function like a result cache for delegate executions returning a result.</para>
@@ -62,26 +73,37 @@
     /// <exception cref="ArgumentNullException">Thrown when <paramref name="cacheProvider"/> is <see langword="null"/>.</exception>
     /// <exception cref="ArgumentNullException">Thrown when <paramref name="ttlStrategy"/> is <see langword="null"/>.</exception>
     /// <exception cref="ArgumentNullException">Thrown when <paramref name="cacheKeyStrategy"/> is <see langword="null"/>.</exception>
-    public static AsyncCachePolicy CacheAsync(IAsyncCacheProvider cacheProvider, ITtlStrategy ttlStrategy, ICacheKeyStrategy cacheKeyStrategy, Action<Context, string, Exception>? onCacheError = null)
+    public static AsyncCachePolicy CacheAsync(
+        IAsyncCacheProvider cacheProvider,
+        ITtlStrategy ttlStrategy,
+        ICacheKeyStrategy cacheKeyStrategy,
+        Action<Context, string, Exception>? onCacheError = null)
     {
-        if (cacheProvider == null)
+        if (cacheProvider is null)
         {
             throw new ArgumentNullException(nameof(cacheProvider));
         }
 
-        if (ttlStrategy == null)
+        if (ttlStrategy is null)
         {
             throw new ArgumentNullException(nameof(ttlStrategy));
         }
 
-        if (cacheKeyStrategy == null)
+        if (cacheKeyStrategy is null)
         {
             throw new ArgumentNullException(nameof(cacheKeyStrategy));
         }
 
         Action<Context, string> emptyDelegate = (_, _) => { };
 
-        return new AsyncCachePolicy(cacheProvider, ttlStrategy, cacheKeyStrategy.GetCacheKey, emptyDelegate, emptyDelegate, emptyDelegate, onCacheError, onCacheError);
+        return new AsyncCachePolicy(
+            cacheProvider,
+            ttlStrategy,
+            cacheKeyStrategy.GetCacheKey,
+            emptyDelegate,
+            emptyDelegate,
+            emptyDelegate,
+            onCacheError, onCacheError);
     }
 
     /// <summary>
@@ -97,7 +119,10 @@
     /// <returns>The policy instance.</returns>
     /// <exception cref="ArgumentNullException">Thrown when <paramref name="cacheProvider"/> is <see langword="null"/>.</exception>
     /// <exception cref="ArgumentNullException">Thrown when <paramref name="cacheKeyStrategy"/> is <see langword="null"/>.</exception>
-    public static AsyncCachePolicy CacheAsync(IAsyncCacheProvider cacheProvider, TimeSpan ttl, Func<Context, string> cacheKeyStrategy, Action<Context, string, Exception>? onCacheError = null) =>
+    public static AsyncCachePolicy CacheAsync(
+        IAsyncCacheProvider cacheProvider,
+        TimeSpan ttl, Func<Context, string> cacheKeyStrategy,
+        Action<Context, string, Exception>? onCacheError = null) =>
         CacheAsync(cacheProvider, new RelativeTtl(ttl), cacheKeyStrategy, onCacheError);
 
     /// <summary>
@@ -114,19 +139,23 @@
     /// <exception cref="ArgumentNullException">Thrown when <paramref name="cacheProvider"/> is <see langword="null"/>.</exception>
     /// <exception cref="ArgumentNullException">Thrown when <paramref name="ttlStrategy"/> is <see langword="null"/>.</exception>
     /// <exception cref="ArgumentNullException">Thrown when <paramref name="cacheKeyStrategy"/> is <see langword="null"/>.</exception>
-    public static AsyncCachePolicy CacheAsync(IAsyncCacheProvider cacheProvider, ITtlStrategy ttlStrategy, Func<Context, string> cacheKeyStrategy, Action<Context, string, Exception>? onCacheError = null)
+    public static AsyncCachePolicy CacheAsync(
+        IAsyncCacheProvider cacheProvider,
+        ITtlStrategy ttlStrategy,
+        Func<Context, string> cacheKeyStrategy,
+        Action<Context, string, Exception>? onCacheError = null)
     {
-        if (cacheProvider == null)
+        if (cacheProvider is null)
         {
             throw new ArgumentNullException(nameof(cacheProvider));
         }
 
-        if (ttlStrategy == null)
+        if (ttlStrategy is null)
         {
             throw new ArgumentNullException(nameof(ttlStrategy));
         }
 
-        if (cacheKeyStrategy == null)
+        if (cacheKeyStrategy is null)
         {
             throw new ArgumentNullException(nameof(cacheKeyStrategy));
         }
@@ -221,8 +250,16 @@
         Action<Context, string> onCacheMiss,
         Action<Context, string> onCachePut,
         Action<Context, string, Exception>? onCacheGetError,
-        Action<Context, string, Exception>? onCachePutError) =>
-        CacheAsync(cacheProvider, new RelativeTtl(ttl), cacheKeyStrategy.GetCacheKey, onCacheGet, onCacheMiss, onCachePut, onCacheGetError, onCachePutError);
+        Action<Context, string, Exception>? onCachePutError)
+    {
+        if (cacheKeyStrategy is null)
+        {
+            throw new ArgumentNullException(nameof(cacheKeyStrategy));
+        }
+
+        return CacheAsync(cacheProvider, new RelativeTtl(ttl), cacheKeyStrategy.GetCacheKey, onCacheGet, onCacheMiss,
+            onCachePut, onCacheGetError, onCachePutError);
+    }
 
     /// <summary>
     /// <para>Builds an <see cref="AsyncPolicy" /> that will function like a result cache for delegate executions returning a result.</para>
@@ -253,8 +290,16 @@
         Action<Context, string> onCacheMiss,
         Action<Context, string> onCachePut,
         Action<Context, string, Exception>? onCacheGetError,
-        Action<Context, string, Exception>? onCachePutError) =>
-        CacheAsync(cacheProvider, ttlStrategy, cacheKeyStrategy.GetCacheKey, onCacheGet, onCacheMiss, onCachePut, onCacheGetError, onCachePutError);
+        Action<Context, string, Exception>? onCachePutError)
+    {
+        if (cacheKeyStrategy is null)
+        {
+            throw new ArgumentNullException(nameof(cacheKeyStrategy));
+        }
+
+        return CacheAsync(cacheProvider, ttlStrategy, cacheKeyStrategy.GetCacheKey, onCacheGet, onCacheMiss, onCachePut,
+            onCacheGetError, onCachePutError);
+    }
 
     /// <summary>
     /// <para>Builds an <see cref="AsyncPolicy" /> that will function like a result cache for delegate executions returning a result.</para>
@@ -318,32 +363,32 @@
         Action<Context, string, Exception>? onCacheGetError,
         Action<Context, string, Exception>? onCachePutError)
     {
-        if (cacheProvider == null)
+        if (cacheProvider is null)
         {
             throw new ArgumentNullException(nameof(cacheProvider));
         }
 
-        if (ttlStrategy == null)
+        if (ttlStrategy is null)
         {
             throw new ArgumentNullException(nameof(ttlStrategy));
         }
 
-        if (cacheKeyStrategy == null)
+        if (cacheKeyStrategy is null)
         {
             throw new ArgumentNullException(nameof(cacheKeyStrategy));
         }
 
-        if (onCacheGet == null)
+        if (onCacheGet is null)
         {
             throw new ArgumentNullException(nameof(onCacheGet));
         }
 
-        if (onCacheMiss == null)
+        if (onCacheMiss is null)
         {
             throw new ArgumentNullException(nameof(onCacheMiss));
         }
 
-        if (onCachePut == null)
+        if (onCachePut is null)
         {
             throw new ArgumentNullException(nameof(onCachePut));
         }