This repository has been archived by the owner on Nov 5, 2020. It is now read-only.
fixed from PVS-Studio #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
V512 A call of the 'sprintf' function will lead to overflow of the buffer 'buffer'. windows_ui.cpp 110 See details in pull request.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm a member of the Pinguem.ru competition on finding errors in open source projects. A bug, found using PVS-Studio.
As you can see, save dialog returns filename with maximal length equals to MAX_PATH (260).
But when you make sprintf it with \n into the buffer, which has 256 length, this may lead to buffer overflow. For example, if you select filename from dialog, which path is 256, 257, 258... characters long.
In this case, the program will crashes.
I set buffer size to MAX_PATH+2 for maximal path and \n and \0 at the end of the line.
V512 A call of the 'sprintf' function will lead to overflow of the buffer 'buffer'. windows_ui.cpp 110