Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test coverage, first working example #101

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

0gust1
Copy link

@0gust1 0gust1 commented Apr 23, 2018

A working prototype of test coverage using Jest and Puppeteer.

How to :

  • launch the dev server (npm run serve) in a shell
  • launch the test runner (node_modules/.bin/jest) in another shell

ATM, only the basic responsive scenario is covered (we test the currentSrc atttribute after page load + some scrolling, for one browser resolution). A lot of things can and should be improved, I just wanted to show a POC on how we can do that.

Todo :

  • launch a small server (no browsersync ?) and the test runner in same command (Travis will be happier, too)
  • some code cleaning and eventually discussion with @ApoorvSaxena on what to test, how to test and how to organize files
  • cover all the functionnalities of the library (including the coverage from js-dom code)
  • Suppress all existing js-dom based test references.

Note : I updated the babel configuration, to better use the babel-env plugin. there is maybe some things to adjust.

Augustin Chassine added 2 commits April 23, 2018 11:11
@0gust1
Copy link
Author

0gust1 commented May 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant