Unit Mine Speed Game Rule Implementation and World Processor Set Rule for Unit Mine Speed, and Unit Crash Damage. #10318
+18
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added unitMineSpeedMultiplier added unitMineSpeed(Team team)
|
Okay seems ready now, I'm probably on the fence on adding crash damage along as well? I have it ready to be easily done... I'll decide in 8 hrs from now prob Wait no, ill just commit it in, it can be reverted |
SomeonesShade
changed the title
|
Why 2 instances of unitMineSpeedMultiplier in Rules.java |
There are 2 instances of everything else, so I just followed Makes sence ish since the value in the rules vs value from the world proc combines (in this case multiplication) |
Ye, nevermind.. didnt notice that one is the global variable and the other is specific to team specific rules |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implmentation
Implements Anuken/Mindustry-Suggestions#5305
Also: Includes Unit Crash Damage in the world proc, mostly for symmetry and completing the unit variable list...
Can be reverted easily probably?
Details
unitminespeed.1.MOV
unitminespeed.2.MOV
unitminespeed.3.MOV
unitcrashdamage.mp4
If your pull request is not translation or serverlist-related, read the list of requirements below and check each box: