Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dev deps and apply linter #14

Merged
merged 6 commits into from
Sep 16, 2024
Merged

Conversation

tonywu71
Copy link
Collaborator

@tonywu71 tonywu71 commented Sep 9, 2024

Description

  • Add the dev dependency group
  • Change minimum supported python version to 3.9 to match colpali-engine
  • Apply linter on pyproject.toml
  • Apply linter on all *.py files

Additional note

The lint options match the ones defined in RAGatouille 🐭

@tonywu71 tonywu71 self-assigned this Sep 9, 2024
@tonywu71 tonywu71 requested a review from bclavie September 9, 2024 20:20
@tonywu71 tonywu71 force-pushed the add-dev-deps-and-apply-linter branch from 7bac2da to 01a10f5 Compare September 9, 2024 20:23
@tonywu71 tonywu71 mentioned this pull request Sep 11, 2024
3 tasks
@bclavie
Copy link
Contributor

bclavie commented Sep 16, 2024

LGTM, thank you ❤️

@bclavie bclavie merged commit dd10e68 into main Sep 16, 2024
1 check passed
@tonywu71 tonywu71 deleted the add-dev-deps-and-apply-linter branch September 16, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants