Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove filter as test which is going to be deprecated #86

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jordiclariana
Copy link

@jordiclariana jordiclariana commented Jul 31, 2018

With Ansible 2.6 this warning is shown:

[DEPRECATION WARNING]: Using tests as filters is deprecated. Instead of using `result|version_compare` use `result 
is version_compare`. This feature will be removed in version 2.9. Deprecation warnings can be disabled by setting 
deprecation_warnings=False in ansible.cfg.

This PR fixes this.

@ernestas-poskus
Copy link
Member

Then we will have to bump required Ansible version https://github.com/AnsibleShipyard/ansible-zookeeper/blob/master/meta/main.yml#L7

@jordiclariana
Copy link
Author

I don't think that is necessary. I made this change here too and I checked against Ansible 2.2 and it worked perfectly, so I think is safe to say it is backwards compatible until Ansible 2.2 at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants