Configurable zookeeper environment vars (#39)

* configurable zookeeper environment vars (useful p.eg to configure logging to file)

* do not write the (empty) zookeeper-env.sh file if the zookeeper_env dict is empty

* extract new zookeeper-env feature into common include

defaults/main.yml

@@ -26,3 +26,6 @@ zookeeper_tarball_dir: /opt/src
 zookeeper_hosts:
   - host: "{{inventory_hostname}}" # the machine running
     id: 1
+
+# Dict of ENV settings to be written into the (optional) conf/zookeeper-env.sh
+zookeeper_env: {}

tasks/common-config.yml

@@ -0,0 +1,7 @@
+---
+- name: Configure zookeeper-env.sh
+  template: src=zookeeper-env.sh.j2 dest={{ zookeeper_dir }}/conf/zookeeper-env.sh owner=zookeeper group=zookeeper
+  tags: deploy
+  notify:
+    - Restart zookeeper
+  when: zookeeper_env is defined and zookeeper_env|length > 0

tasks/main.yml

@@ -8,3 +8,5 @@
 
 - include: RedHat.yml
   when: ansible_os_family == 'RedHat'
+
+- include: common-config.yml

tasks/tarball.yml

@@ -34,7 +34,7 @@
   notify:
     - Restart zookeeper
 
-- name: Configure zookeeper
+- name: Configure zookeeper zoo.cfg
   template: src=zoo.cfg.j2 dest={{ zookeeper_dir }}/conf/zoo.cfg owner=zookeeper group=zookeeper
   tags: deploy
   notify:

templates/zookeeper-env.sh.j2

@@ -0,0 +1,5 @@
+{% if zookeeper_env is defined %}
+{% for key, value in zookeeper_env.items() | sort %}
+{{key}}={{value}}
+{% endfor %}
+{% endif %}