Zookeeper setup using offical tarball (also) on debian/ubuntu (#34)

* added support to setup zookeeper on debian/ubuntu from the official tarball (same as existing redhat/centos setup)

* undo addition of deb-uninstall

* added debian/ubuntu specific role variable that selects either upstart or systemd for the init script

* update min_ansible_version to 1.6

defaults/main.yml

@@ -4,7 +4,12 @@ zookeeper_playbook_version: "0.9.2"
 zookeeper_version: 3.4.6
 zookeeper_url: http://www.us.apache.org/dist/zookeeper/zookeeper-{{zookeeper_version}}/zookeeper-{{zookeeper_version}}.tar.gz
 
+# Flag that selects if systemd or upstart will be used for the init service:
+# Note: by default Ubuntu 15.04 and later use systemd (but support switch to upstart)
+zookeeper_debian_systemd_enabled: "{{ ansible_distribution_version|version_compare(15.04, '>=') }}"
+zookeeper_debian_apt_install: false
 apt_cache_timeout: 3600
+
 client_port: 2181
 init_limit: 5
 sync_limit: 2

meta/main.yml

@@ -4,7 +4,7 @@ galaxy_info:
   description: Ansible Zookeeper Role
   company: http://michaelhamrah.com
   license: Apache 2
-  min_ansible_version: 1.2
+  min_ansible_version: 1.6
   #
   # Below are all platforms currently available. Just uncomment
   # the ones that apply to your role. If you don't see your 

tasks/Debian-tarball.yml

@@ -0,0 +1,14 @@
+---
+- include: tarball.yml
+
+- include: upstart.yml
+  when: not zookeeper_debian_systemd_enabled
+  tags: deploy
+
+- include: systemd.yml
+  when: zookeeper_debian_systemd_enabled
+  tags: deploy
+
+- name: Start zookeeper
+  service: name=zookeeper state=started enabled=yes
+  tags: deploy

tasks/main.yml

@@ -1,6 +1,10 @@
 ---
+
 - include: Debian.yml
-  when: ansible_os_family == 'Debian'
+  when: ansible_os_family == 'Debian' and zookeeper_debian_apt_install
+
+- include: Debian-tarball.yml
+  when: ansible_os_family == 'Debian' and not zookeeper_debian_apt_install
 
 - include: RedHat.yml
   when: ansible_os_family == 'RedHat'

templates/zookeeper.conf.j2

@@ -13,5 +13,5 @@ umask 007
 kill timeout 300
 
 script
-    su -c "{{zookeeper_dir}}/bin/zkServer.sh start-foreground > /var/log/zookeeper/init-zookeeper.log" zookeeper
+    exec sudo -u zookeeper -g zookeeper {{zookeeper_dir}}/bin/zkServer.sh start-foreground > /var/log/zookeeper/init-zookeeper.log 2>&1
 end script