add flag to control logging level #48
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems that the zookeeper role is trying to pull a version that has been bumped already. |
ernestas-poskus
requested changes
Jul 8, 2018
tasks/conf.yml
Outdated
| @@ -47,6 +47,11 @@ | |||
| when: marathon_mesos_role != "" | |||
| notify: Restart marathon | |||
|
|
|||
| - name: Set optional --logging_level option | |||
| template: src=logging_level.j2 dest=/etc/marathon/conf/logging_level | |||
| when: marathon_logging_level != "" or marathon_logging_level != "info" | |||
There was a problem hiding this comment.
marathon_logging_level != "info" this brings cofusion to one who will set variable to info level, maybe just leave first part?
There was a problem hiding this comment.
You're right. I've updated it.
chicofranchico
force-pushed
the
master
branch
2 times, most recently
from
ed4e133 to
4cd5c10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used a less generic variable name
marathon_logging_levelso that it doesn't clash with other possible roles.