Interim indexed-color (256-color) Rendering #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add: `TextImage._get_render_data()`, implementing image quantization for text-based styles towards indexed-color rendering support. - Add: `TextImage._XTERM_240_PALETTE_IMAGE`.
- Add: `DIRECT` and `INDEXED` render methods. - Add: *method* style parameter and format spec field. - Add: Attributes: - `_FORMAT_SPEC` - `_render_methods` - `_default_render_method` - `_render_method` - `_style_args` - Add: `._check_style_format_spec()`. - Add: *method* parameter to `._render_image()`. - Change: Update class docstring.
- Add: Use the *method* parameter of `._render_image()`. - Add: Implement the `INDEXED` render method.
- Fix: Typo in `._get_render_data()`.
- Add: Mention indexed-color support in the requirements. - Change: Update the list of supported terminal emulators.
AnonymouX47
added
block
AnonymouX47
force-pushed
the
indexed-color
branch
from
5bf9659
to
bf0c509
Compare
AnonymouX47
force-pushed
the
indexed-color
branch
from
bf0c509
to
a264c66
Compare
AnonymouX47
force-pushed
the
indexed-color
branch
from
a264c66
to
52edf2b
Compare
This was referenced May 31, 2024
- Fix: Use the non-standard semi-colon-delimited indexed-color SGR control sequences, as they're more widely supported than the standard colon-delimited counterparts. Refs: #90 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DIRECTandINDEXEDrender methods forBlockImage.BlockImage.Resolves #90
Partially addresses #61
Note
This is just an implementation to satisfy demand in the meantime, while we await full resolution of #61.
For this reason, this will only be merged into v0.7.x and not
main.